search

ACED-IDP / gen3-helm

Helm charts for Gen3 Deployments
Apache License 2.0
1 stars 0 forks source link

Improving SS as a source of truth (#56) #57

Closed quinnwai closed 1 day ago

quinnwai commented 4 days ago

Addressing #56

Thinking through user story

  1. I have changes I want to make to local, so I...

    cp Secrets-local Secrets-local_test
make push-secrets DEPLOY=local_test

  2. Once it's updated in SS, other people can test those changes by...

    
make fetch-secrets DEPLOY=local_test` (writes to `Secrets-local_test/` dir)
rm -r Secrets/
ln -s Secrets-local_test Secrets

TODO: some level of testing on their local, eg

make clean && make update && make local 


3. With other's approval, I update the true local with...
```bash
make push-secrets DEPLOY=local_test
rm -r Secrets-local_test/

Descriptions / commit messages

Tried to create a description to add to each action, but the actions in the Audit (ie history tab) are not editable. Let me know if you think commit messages / descriptions are still important or if we should just leave it

matthewpeterkort commented 4 days ago

Need to test but overall this looks good to me.

Tested and working. LGTM