ACED-IDP / gen3_util

Collection of command line tools to interact with a Gen3 instance
MIT License
3 stars 1 forks source link

Feature/aced rbac #21

Closed bwalsh closed 1 year ago

bwalsh commented 1 year ago

This PR:

matthewpeterkort commented 1 year ago

Some of the older pytests are failing because the commands have changed since last PR, or some of the tests are expected to fail for one reason or another. 7 tests failed 31 tests passed:

  1. pytest tests/integration/test_files.py::test_files_upload fails because the command gen3_util meta import no longer exists
  2. pytest tests/integration/test_access.py::test_files_upload_bad_source fails because even though it returns Unable to get a presigned URL for download: 404 Client Error: Not Found for url: https://aced-training.compbio.ohsu.edu/user/data/download/foo the test exits in a code 0 when it should exit with a 1, but this overall seems like the intended result to me.
  3. pytest tests/integration/test_access.py::test_access_workflowdidn't seem to produce any intended error but hit the obj, end = self.scan_once(s, idx) line and went to theStopIteration exception so maybe it had already been run once and was supposed to fail.
  4. pytest tests/integration/test_files.py::test_workflow errors because old command gen3_util meta import
  5. pytest tests/unit/test_cli.py::test_meta failed because the first help on the publish command is splitting halfway through the sentenceat the from_ and not at the end of the line. The command contents itself seems to be matching though.
  6. pytest tests/integration/test_meta.py::test_incremental_workflow seems to be hitting a similar error as pytest tests/integration/test_access.py::test_access_workflow and failing at the json decode. This looks like an older test. Maybe just needs to be updated with the newer gen3_util projects add resource test-myproject style command