search

ACES-CMZ / reduction_ACES

Reduction scripts and tools for ACES
https://worldwidetelescope.org/webclient/?wtml=https://data.rc.ufl.edu/pub/adamginsburg/ACES/mosaics/mosaics.wtml
15 stars 12 forks source link

Make reimaging pipeline build the clean parameters for us? #212

Open keflavich opened 2 years ago

keflavich commented 2 years ago

@d-l-walker Maybe we can do what you said.

Should we just add nbins=1 to this line?

https://github.com/ACES-CMZ/reduction_ACES/blob/47c58361978b795223d3b7cf0613743a4dca3b0c/aces/pipeline_scripts/imaging_pipeline_rerun.py#L54

That will at least make the reimaging pipeline output a default set of parameters.

But, see https://github.com/ACES-CMZ/reduction_ACES/issues/211 - we probably want to override them anyway.

d-l-walker commented 2 years ago

I think that'd be nice and effectively automate the re-binning for us. Though we'd need to use pipelinemode='interactive' instead of automatic. I think it should fill the remaining parameters automatically anyway, but not 100% sure(?). It's possible we may need to explicitly state some other parameters in this mode.

And yeah, I agree with #211 -- it makes sense to have a common grid.

keflavich commented 2 years ago

What do pipelinemode='interactive' and ='automatic' do, then? Go ahead and propose the change in a PR - I'm not entirely clear where these parameters belong.

d-l-walker commented 2 years ago

I'll do a bit of local testing first as I'm not 100% sure myself. Once I've done that I'll propose the change(s).