search

ACEsuit / ACE.jl

Parameterisation of Equivariant Properties of Particle Systems
65 stars 15 forks source link

Equiv #21

Closed MatthiasSachs closed 3 years ago

MatthiasSachs commented 3 years ago

First working version for EuclidianVector-basis

Relevant tests are provided in test/test_symmbasis-equiv.jl

The test sets is not yet added to the general test set.

cortner commented 3 years ago

thank you - will start reviewing asap

cortner commented 3 years ago

actually, I'm going to start with a request - can you please make the PR to merge into equiv and not into master?

cortner commented 3 years ago

hm.... I'm really confused,. Are you trying to merge ACEsuit/equiv into master here? I think you need to try and merge MatthiasSachs/equiv into ACEsuit/equiv.

cortner commented 3 years ago

happy easter :)

MatthiasSachs commented 3 years ago

happy easter! :) arghh, sorry, I think I will need to create a new pull request. I did not very carefully review into which branch I am attempting to merge it...