ACEsuit / ACE.jl

Parameterisation of Equivariant Properties of Particle Systems
65 stars 15 forks source link

m range in product basis #57

Closed cortner closed 2 years ago

cortner commented 3 years ago

In function indexrange we have the following

   # HACK: fix the m range based on the maximal l-range
   #       this needs to be suitably generalised if we have multiple
   #       (l, m) pairs, e.g. (l1, m1), (l2, m2)
   if haskey(rg, :m)
      maxl = maximum(rg[:l])
      rg[:m] = collect(-maxl:maxl)
   end

says it all ...

cortner commented 2 years ago

this was fixed in v0.12.16