search

ACEsuit / ACE.jl

Parameterisation of Equivariant Properties of Particle Systems
66 stars 15 forks source link

Typo in `function _gensparse(...)` #63

Closed MatthiasSachs closed 2 years ago

MatthiasSachs commented 2 years ago

Should isadmissible in line 76 (part of function _gensparse(...)) in sparsegrids.jl

if all(minvv .== 0) && isadmissible(vv) && filter(vv)

be admissible ?

cortner commented 2 years ago

that's likely true, just never came up because we never use the 0 correlation-order. I will look into it though.

cortner commented 2 years ago

@MatthiasSachs I think you fixed this in one of the recent PRs?