ACEsuit / ACEfit.jl

Generic Codes for Fitting ACE models
MIT License
7 stars 6 forks source link

v0.0.4 #42

Closed wcwitt closed 1 year ago

wcwitt commented 1 year ago

@cortner, would you please bump ACEfit to v0.0.4? There aren't many new changes from v0.0.3, but @gelzinyte and I are trying to bring ACE1pack back to a state where the tests pass, and this is a prerequisite.

cortner commented 1 year ago

You have a deprecation warning

┌ Warning: `getindex(o::PyObject, s::AbstractString)` is deprecated in favor of dot overloading (`getproperty`) so elements should now be accessed as e.g. `o."s"` instead of `o["s"]`.
│   caller = linear_solve(solver::ACEfit.SKLEARN_BRR, A::Matrix{Float64}, y::Vector{Float64}) at solvers.jl:143
└ @ ACEfit ~/gits/ACEfit.jl/src/solvers.jl:143

Not urgent, but can you fix this maybe with the next PR?

cortner commented 1 year ago

done.