search

ACEsuit / ACEfit.jl

Generic Codes for Fitting ACE models
MIT License
7 stars 6 forks source link

Maxiter for Bayesian Solvers #44

Closed cortner closed 1 year ago

cortner commented 1 year ago

LSQR has a maxiter parameter but the Bayesian solvers do not. For some problems they just seem to not converge (cf Slack discussion). They should all get this parameter please, and then they should fail with a nice user-friendly message, something along the lines of "even when the solver hasn't converged the quality of the solution may be good, please test this before changing solver parameters"

cortner commented 1 year ago

I think once this is added we can rerun our benchmarks with the pure-Julia BLR

wcwitt commented 1 year ago

Thanks - completely agree

wcwitt commented 1 year ago

This was already on the todo list here, so I'm going to close and focus on that issue.