search

ACEsuit / ACEfit.jl

Generic Codes for Fitting ACE models
MIT License
7 stars 7 forks source link

Truncated SVD #74

Closed cortner closed 6 months ago

cortner commented 6 months ago

continue Jerry's PR for adding the truncated SVD

cortner commented 6 months ago

I changed naming to be consistent with Julia conventions. I fix the inline docs, and I messed a bit with one of the test files. It really needs more tests I think but it would be ok to merge this now so it becomes usable.

@wcwitt -- are you happy for us to merge this and tag a new version?

wcwitt commented 6 months ago

Thanks - looks interesting!

Once the previous comment is resolved (and the tests are passing) I'm happy for you to merge.

wcwitt commented 6 months ago

The CI ran successfully, so happy for you to merge and tag.

cortner commented 6 months ago

registered as v"0.1.5"