ACEsuit / ACEfit.jl

Generic Codes for Fitting ACE models
MIT License
7 stars 6 forks source link

Bayesian regression with `:cholesky` not returning committee #75

Closed CheukHinHoJerry closed 5 months ago

CheukHinHoJerry commented 5 months ago
# calling bayesian_fit in `bayesian_linear_regression`
return bayesian_fit(A, Y;
                            variance_c_floor = sig_0_floor * sig_0_floor,
                            variance_e_floor = sig_e_floor * sig_e_floor,
                            verbose = verbose)

# some code in between ...

function bayesian_fit(...)

   C = solve(y, X, var_c, var_e)
   return Dict("C" => C)

Seems that committee is not returned when we use Cholesky factorization for the BLR solver. Maybe worth a warning so that the users aware? It took me some time to look into the code and figure out why the committee is not return even if committee_size > 0.

wcwitt commented 5 months ago

Good point. Link #66.