[x] Normalisation Ylm and Rlm: Verify the normalized constant for both solid harmonics and spherical harmonics, document this in the Polynomials4ML docs, check if there are other ways to normalize them, including the sense of norm used. -- @DexuanZhou
[x] Unit tests for Rlm: verify they match the explicit expressions, check derivatives, follow test_cylm.jl -- @DexuanZhou
[x] Unit tests for atomic orbitals: for Gaussian, Slater, and STO-NG functions. Check the derivatives of these functions and also verify the consistency of the standard and batched evaluation methods. -- @DexuanZhou
[x] SparseProduct: implement a sparse product without pooling in Polynomials4ML from which we can build atomic orbital bases -- @cortner and @CheukHinHoJerry
[x] AtomicOrbitalsBasis: implement the atomic orbitals basis which will be evaluating the atomic orbitals on multiple nuclei and merging them into a single basis. -- TBD
[x] BackflowPooling: implement the custom backflow pooling as a separate operation from the AtomicOrbitalsBasis -- @cortner and @CheukHinHoJerry
[x] Reorganize atorbbasis.jl : once the AtomicOrbitalsBasis and BackflowPooling is done, we can reorganize this into a very simple flux layer or chain -- TBD
[ ] Correlations: Here we should be able to just use the standard implementation. But we do need to implement some scripts that will give us different choices of which correlations to involve in the model. This is where the real modelling happens!! -- @DexuanZhou (??)
[ ] Clearly document the API
Additional comment that I don't fully understand yet - to be discussed in our next meeting?
cortner
commented
1 year ago
Updates from this PR, a list copy from #17 :
test_cylm.jl-- @DexuanZhouAdditional comment that I don't fully understand yet - to be discussed in our next meeting?
Some additional features:
HyperDualsfor Laplacian evaluationLuxintegration