search

ACEsuit / IPFitting.jl

Fitting of NBodyIPs
Other
5 stars 10 forks source link

add_fits! prints progress bar #33

Open davkovacs opened 2 years ago

davkovacs commented 2 years ago

add_fits! prints a progress bar by default, but usually we submit jobs, and the progress bar gets outputted into a file, and looks quite bad + doesn't add much. I traced it back to come from verbose = true by default here: https://github.com/ACEsuit/IPFitting.jl/blob/628f335092bd8b79425d954502a232fd70460cf9/src/obsiter.jl#L81-L84

If people agree could we change this default to false ?

casv2 commented 2 years ago

I see what you mean, on a laptop it looks great, as output from the HPC it ends up looking a bit weird. I don't see why not

davkovacs commented 2 years ago

@cortner what is the current policy on tiny changes like this?

cortner commented 2 years ago

On IPFitting it should be a separate PR, on ACE1suit just add it somewhere.

But I would maybe caution. Is there a way to generally have different defaults for HPC vs local? Should there be a progress update but formatted differently?