ACEsuit / Polynomials4ML.jl

Polynomials for ML: fast evaluation, batching, differentiation
MIT License
12 stars 5 forks source link

WIP: add interfaces for SpheriCart ylm #76

Closed zhanglw0521 closed 7 months ago

zhanglw0521 commented 10 months ago

This PR links SpheriCart to P4ML, trying to make the evaluation of SHs and their derivatives more efficient in the resulting LuxChain.

cortner commented 8 months ago

can I review and merge?

zhanglw0521 commented 8 months ago

Thanks for checking the status. There are still one or two small details that I need to double-check. I will get this ready to be reviewed very soon and will let you know then.

cortner commented 7 months ago

I would like to register sphericart in General first, and then we can merge and tag.

cortner commented 7 months ago

change of plans - I'm merging this into a new branch lz/sphericart so we can finalize and test the branch centrally. @zhanglw0521 -- I'll give you access of course.