ACEsuit / Polynomials4ML.jl

Polynomials for ML: fast evaluation, batching, differentiation
MIT License
12 stars 5 forks source link

AtomicOrbitals don't follow Lux rules #86

Open cortner opened 3 months ago

cortner commented 3 months ago

Lux layers (and also ours) must be immutable. This rule is not followed in the atomicorbitalsradials implementation. What is currently done doesn't look immediately dangerous so this is not a huge rush to fix. But for the sake of consistency of code style we should discuss whether or how to fix this.