ACEsuit / mace

MACE - Fast and accurate machine learning interatomic potentials with higher order equivariant message passing.
Other
412 stars 155 forks source link

Add Command-Line Argument for Specifying Wandb Directory #466

Closed nqhq-lou closed 1 week ago

nqhq-lou commented 2 weeks ago

Issue: This PR addresses issue #433, which involves adding a command-line argument to specify the wandb directory.

Changes:

  1. Added --wandb_dir in mace.tools.arg_parser.build_default_arg_parser(). The arg default is None to preserve the default wandb directory settings.
  2. Added keyword directory in mace.tools.torch_tools.init_wandb(). All associated function calls are adapted to the new keyword.

Code behavior:

with --wandb_dir:

without --wandb_dir:

nqhq-lou commented 1 week ago

@ilyes319 Hi Ilyes, how does this PR look like? For the failed testing I checked the output logs and it tells some package errors. This PR is actually quite simple so I think maybe it would be safe to merge.

ilyes319 commented 1 week ago

yep can you just update your fork with the latest develop, it should make the test pass.

nqhq-lou commented 1 week ago

Just merged branch develop into this branch! Please approve the testing workflow.