Closed nqhq-lou closed 1 week ago
@ilyes319 Hi Ilyes, how does this PR look like? For the failed testing I checked the output logs and it tells some package errors. This PR is actually quite simple so I think maybe it would be safe to merge.
yep can you just update your fork with the latest develop, it should make the test pass.
Just merged branch develop into this branch! Please approve the testing workflow.
Issue: This PR addresses issue #433, which involves adding a command-line argument to specify the wandb directory.
Changes:
--wandb_dir
inmace.tools.arg_parser.build_default_arg_parser()
. The arg default isNone
to preserve the default wandb directory settings.directory
inmace.tools.torch_tools.init_wandb()
. All associated function calls are adapted to the new keyword.Code behavior:
with
--wandb_dir
:command:
directory structure:
As expected the wandb metadata dir is relocated as specified by
--wandb_dir
without
--wandb_dir
: