ACF-Team / ACF-3

ACF
MIT License
67 stars 55 forks source link

Contraption weight check reads incorrectly on dupes with physclipped props. [BUG] #270

Closed bluemetaknight closed 2 years ago

bluemetaknight commented 2 years ago

When using the ACF Armor Tool's weight check function, the chat box print will read incorrectly if a contraption with physclipped props is checked after the contraption has been duped and respawned.

https://drive.google.com/file/d/1LzLllvneAcFLbWYsD_z9Vk-48jFmY9Kq/view?usp=sharing This picture shows the dupes weight being checked post spawn by clicking R on the non clipped prop. Weight reads 909 kg.

https://drive.google.com/file/d/1Z91Mk8RAfA1orbazazdv6UrpRiWNuFV4/view?usp=sharing This picture shows the dupe being checked post spawn, but by clicking R on the physclipped prop. Weight now reads 722.6 kg.

https://drive.google.com/file/d/1SA-A_j8cB3shZqjm6aez2KyT77tK0OvL/view?usp=sharing This picture shows the dupe being checked post spawn again but with spherical search and by clicking on the non clipped prop.

This seems to suggest that the mass for physclipped props isn't updated post spawn until they are looked at directly by the ACF Armor Tool, or by weight checking with spherical search.

https://drive.google.com/file/d/1AYE5j7wF7frROxVJtlTVr1lo8O4eAQvI/view?usp=sharing

Here's a copy of the dupe in order to replicate the issue.

Branch: GitHub Master, most recent version.

Stooberton commented 2 years ago

Looking at the prop causes the prop's ACF data to update, which shows a different value. This indicates to me that something changes the mass after ACF did when pasting.

My best guess:

LeninCat commented 2 years ago

saw this happen with my tank. tank's weight will change after running area weight check aswell

Stooberton commented 2 years ago

image

Stooberton commented 2 years ago

Fixed in a8d4909bf991cd30487cb584d6b85ac5fa086c0d