search

ACF-Team / ACF-3

ACF
MIT License
69 stars 56 forks source link

Gearboxes unlink their wirelink when updated [BUG] #273

Closed Amplar closed 2 years ago

Amplar commented 2 years ago

As it says on the tin, transfer cases and possibly others are unlinking wirelink to e2 after updating.

TwistedTail commented 2 years ago

Any more details on this? I don't really understand the issue.

Amplar commented 2 years ago

Wirelink a gearbox to an E2, and update the ratios on the gearbox. The wirelink will unlink.

Stooberton commented 2 years ago

Happens with guns and radars too... But not engines, interestingly. Doesn't require any actual settings to be changed, just causing an update breaks the wirelink.

Stooberton commented 2 years ago

Calling WireLib.AdjustOutputs is breaking the wirelink when an entity is updated. Wiremod bug/inconsistent behavior since wires aren't destroyed when outputs are adjusted.

Stooberton commented 2 years ago

PR up to fix WireLib.AdjustOutputs breaking wirelinks.

https://github.com/wiremod/wire/pull/2314

TwistedTail commented 2 years ago

Fixed on https://github.com/wiremod/wire/pull/2314.