search

ACF-Team / ACF-3

ACF
MIT License
67 stars 55 forks source link

[BUG] Scalable armor can surpass armor limit set by server owner #279

Closed Ally-for-Hire closed 1 year ago

Ally-for-Hire commented 2 years ago

Short Description

Scalable armor can surpass armor limit set by server owner. Ex: on servers like Valen with a 600mm armor limit you can have 1kmm+ of armor with scalable armor entity

Branch and Version

As long as scalable armor has existed idk man

How to Reproduce (Optional)

Scalable armor, max the slider, profit

OctothorpeObelus commented 2 years ago

This is a pretty simple fix I can do when I get home.

Stooberton commented 2 years ago

Is it that simple? The way armor is calculated on pArmor is through actual line of sight thickness. If we put a cap on one axis, it doesn't stop anyone from making the plate much thicker on another axis and just rotating it.

OctothorpeObelus commented 2 years ago

You make a good point there, I'll admit I hadn't considered that, though it wouldn't be very practical for someone to do, as rotating it 90 degrees makes one side dependent on maximum thickness which would mean it could be nullified/broken by the cvar and leave gaps. Not to mention the increased ent count to do it that way.

TwistedTail commented 2 years ago

If we put a cap on one axis, it doesn't stop anyone from making the plate much thicker on another axis and just rotating it.

We could probably just find the thinnest axis and apply the limit on it.

homura-akemi-f02-22 commented 2 years ago

How about making scalable armour sync better with optical thickness? And armour weight too

TwistedTail commented 2 years ago

How about making scalable armour sync better with optical thickness?

Optical thickness?

And armour weight too

Scalable armor already uses the volume of the entity and the density of the material to calculate its mass, it should be as accurate as possible already.

homura-akemi-f02-22 commented 2 years ago

optical thickness as in visual thickness

On Tue, 20 Sept 2022 at 17:48, TwistedTail @.***> wrote:

How about making scalable armour sync better with optical thickness?

Optical thickness?

And armour weight too

Scalable armor already uses the volume of the entity and the density of the material to calculate its mass, it should be as accurate as possible already.

— Reply to this email directly, view it on GitHub https://github.com/Stooberton/ACF-3/issues/279#issuecomment-1252629348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUYFQNBWOPB2RDNOX2ZQPIDV7HTHXANCNFSM5RLSKU3Q . You are receiving this because you commented.Message ID: @.***>

TwistedTail commented 2 years ago

optical thickness as in visual thickness

That's how it works already, bullets use the actual size of the entity, along with taking into consideration the density of the material to get a RHA equivalent value, to calculate the armor they have to go through whenever they hit a scalable armor plate.

homura-akemi-f02-22 commented 2 years ago

thanks

On Wed, 21 Sept 2022 at 06:14, TwistedTail @.***> wrote:

optical thickness as in visual thickness

That's how it works already, bullets use the actual size of the entity, along with taking into consideration the density of the material to get a RHA equivalent value, to calculate the armor they have to go through whenever they hit a scalable armor plate.

— Reply to this email directly, view it on GitHub https://github.com/Stooberton/ACF-3/issues/279#issuecomment-1253215473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUYFQNCCLMCENYGNFBR743TV7KKU5ANCNFSM5RLSKU3Q . You are receiving this because you commented.Message ID: @.***>