search

ACF-Team / ACF-3

ACF
MIT License
67 stars 54 forks source link

Check if entity is valid and remove unused local #320

Closed wrefgtzweve closed 1 year ago

wrefgtzweve commented 1 year ago

SV error:

addons/acf-3/lua/acf/damage/damage_sv.lua:671: Tried to use a NULL entity!
   0.  unkown - [C]:-1
    1.  GetPos - [C]:-1
     2.  ACF_APKill - addons/acf-3/lua/acf/damage/damage_sv.lua:671
      3.  DoRoundImpact - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:330
       4.  Func - addons/acf-3/lua/acf/entities/ammo_types/he.lua:94
        5.  OnImpact - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:170
         6.  DoBulletsFlight - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:270
          7.  CalcBulletFlight - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:87
           8.  CreateBullet - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:156
            9.  Detonate - addons/acf-3-missiles/lua/entities/acf_missile/init.lua:615
             10.  CalcFlight - addons/acf-3-missiles/lua/entities/acf_missile/init.lua:268
              11.  unkown - addons/acf-3-missiles/lua/entities/acf_missile/init.lua:625

and

addons/acf-3/lua/acf/damage/damage_sv.lua:671: Tried to use a NULL entity!
   1.  unknown - [C]:-1
    2.  GetPos - [C]:-1
     3.  ACF_APKill - addons/acf-3/lua/acf/damage/damage_sv.lua:671
      4.  DoRoundImpact - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:330
       5.  Func - addons/acf-3/lua/acf/entities/ammo_types/he.lua:94
        6.  OnImpact - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:170
         7.  DoBulletsFlight - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:270
          8.  CalcBulletFlight - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:87
           9.  CreateBullet - addons/acf-3/lua/acf/ballistics/ballistics_sv.lua:156
            10.  Create - addons/acf-3/lua/acf/entities/ammo_types/ap.lua:99
             11.  CookoffCrate - addons/acf-3/lua/entities/acf_ammo/init.lua:445
              12.  unknown - addons/acf-3/lua/entities/acf_ammo/init.lua:513

Removed the local and table insert as ACF_APKill never returns anything anyway image

The IsValid could also be placed in ACF_APKill itself but considering I've only seen this error happen through this line i felt like fixing it here would be better.