search

ACHMartin / seastar_project

4 stars 0 forks source link

Raise an error if the polarisation is not in the correct format in compute_wasv (applicable for nrcs?) #212

Open ACHMartin opened 1 year ago

ACHMartin commented 1 year ago

In compute_wasv: for pol_str, pol_val in [('VV', 1), ('HH', 2)]: ind[pol_str] = (L1.Polarization == pol_str).values

We need to test if the outputs is full of False (for exemple using .any() )

ACHMartin commented 1 year ago

link with #206 and #211

ACHMartin commented 1 year ago

Is the Polarization an image or a single string? In a far future, we might want to have non perfect VV/HH polarisation and might wish to have an interpolation in between. I would favour a "float" value which will make things easier for the interpolation. I would prefer to have a Polarisation "Image" which give us more flexibility.

DavidMcCann-NOC commented 1 year ago

Currently its a string, but I think i see what you mean. I have made the polarization into an image in the multi-antenna compute_wasv implementation to get my changes to mesh with how you originally handled the polarization but perhaps I have been a little confused by it.

ACHMartin commented 1 year ago

On my branch I implement news tools PolarisationString2Values and the other way around. You might 'rebase' from my branch. I only committed and pushed complete functions. I also did modification on compute_nrcs with polarisation as an Image. For compute_wasv, the current implementation in the main branch, works with a Polarisation Image.