search

ACINQ / bitcoin-kmp

Kotlin Multiplatform Bitcoin Library
Apache License 2.0
68 stars 15 forks source link

Add partial support for PSBT Taproot Fields (BIP371) #128

Closed sstone closed 2 months ago

sstone commented 4 months ago

We only add what is necessary to create, update and sign taproot (BIP86) outputs.

t-bast commented 2 months ago

It seems to me that PSBTv2 is something completely different from adding taproot or musig fields to PSBT. Can you clarify exactly what is covered by this PR? As far as I understand, Bitcoin Core hasn't merged support for PSBTv2 yet (which gets rid of the global tx field), so we should stick to PSBTv0 and just add support for BIPs 371 and 373?

sstone commented 2 months ago

It seems to me that PSBTv2 is something completely different from adding taproot or musig fields to PSBT. Can you clarify exactly what is covered by this PR? As far as I understand, Bitcoin Core hasn't merged support for PSBTv2 yet (which gets rid of the global tx field), so we should stick to PSBTv0 and just add support for BIPs 371 and 373?

Yes I've updated the PR description and commit message, here I'm just adding what we need to support p2tr wallets in eclair.