Improvements and bug fixes for BIP 371 support - Githubissues

ACINQ / bitcoin-kmp

Kotlin Multiplatform Bitcoin Library

Apache License 2.0

68 stars 15 forks source link

Improvements and bug fixes for BIP 371 support #134

Closed t-bast closed 2 months ago

t-bast commented 2 months ago

This commit fixes my comments made on #128 and adds a few improvements:

fix a bug in the index used for previous inputs
use InvalidTxOutput for invalid taproot output fields
add test vectors from BIP 371
reformat to match the rest of the file

Note that I updated the "build and sign a BIP86 psbt" test to include a non-segwit input, this way it fails without the fix to the input index.

Note: this is a PR targetting the #128 branch.