ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.24k stars 266 forks source link

Update to bitcoind 24.1 #2711

Closed t-bast closed 1 year ago

t-bast commented 1 year ago

This lets us use the new gettxspendingprevout instead of fetching the whole mempool when looking for txs spending one of our channels.

I had to change many of the test values in InteractiveTxBuilderSpec because bitcoind updated the way it generates the change output in https://github.com/bitcoin/bitcoin/pull/24494 which had mostly an impact on outputs around the 50k sat threshold. Bitcoin Core tries to create a change output with an amount similar to the main output for privacy reason (and has done so for a few versions already). While this makes sense for most users, it creates more liquidity churn for LSPs: ideally that's something we'd like to turn off (we probably don't want to pay for privacy). We may want to start using our own fork of bitcoind with small coinselection tweaks if we want to preserve our utxo set.

codecov-commenter commented 1 year ago

Codecov Report

Merging #2711 (3510ee5) into master (3e43611) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #2711      +/-   ##
==========================================
+ Coverage   85.96%   85.98%   +0.01%     
==========================================
  Files         215      215              
  Lines       17731    17731              
  Branches      765      775      +10     
==========================================
+ Hits        15243    15246       +3     
+ Misses       2488     2485       -3     
Impacted Files Coverage Δ
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 87.20% <100.00%> (-0.11%) :arrow_down:
...ir/blockchain/bitcoind/rpc/BitcoinCoreClient.scala 98.46% <100.00%> (+0.02%) :arrow_up:

... and 5 files with indirect coverage changes