search

ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.24k stars 266 forks source link

eclair sets fix description "Donation" for all received keysend payments instead of message from sender #2724

Closed DerEwige closed 1 year ago

DerEwige commented 1 year ago

version=0.9.0 commit=623f7e4

When eclair receives a keysend it generates a fake matching invoice to be stored in payments.received. This invoice always gets a generic description "Donation" insted of the message sent by the sender.

keysend is used for more than just sending sats to a peer. It is used to chat with peers or even to trigger commands, etc.

it should be possible to see this messages from the keysend sender so we can parse them in plugins and interact with our peers.

DerEwige commented 1 year ago

I just realised this is more a missing feature then a bug:

eclair only implementent PushPayment but not Basic Messages

https://github.com/alexbosworth/keysend_protocols

t-bast commented 1 year ago

I don't think we plan on supporting that at the moment. Keysend was always a somewhat hacky temporary feature, so we only implement what is inside the blip. Our goal is not to support messages through payments, we introduced onion messages for that and Bolt 12 will provide cleaner ways of paying for that kind of scenarios.