ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.24k stars 266 forks source link

Add `require_confirmed_inputs` to RBF messages #2783

Closed t-bast closed 8 months ago

t-bast commented 11 months ago

This was missing from the spec, but is more flexible and clearer than inheriting values from the previous attempt. The dual funding specification added this in https://github.com/lightning/bolts/pull/851/commits/27ffef47aee985d37dcef85d528719f9a4608400

Fixes #2782

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (61f1e1f) 85.85% compared to head (5aa515d) 85.89%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2783 +/- ## ========================================== + Coverage 85.85% 85.89% +0.04% ========================================== Files 216 216 Lines 18188 18201 +13 Branches 780 776 -4 ========================================== + Hits 15615 15634 +19 + Misses 2573 2567 -6 ``` | [Files](https://app.codecov.io/gh/ACINQ/eclair/pull/2783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ) | Coverage Δ | | |---|---|---| | [...inq/eclair/channel/fsm/ChannelOpenDualFunded.scala](https://app.codecov.io/gh/ACINQ/eclair/pull/2783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ#diff-ZWNsYWlyLWNvcmUvc3JjL21haW4vc2NhbGEvZnIvYWNpbnEvZWNsYWlyL2NoYW5uZWwvZnNtL0NoYW5uZWxPcGVuRHVhbEZ1bmRlZC5zY2FsYQ==) | `87.03% <100.00%> (+0.55%)` | :arrow_up: | | [...ala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala](https://app.codecov.io/gh/ACINQ/eclair/pull/2783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ#diff-ZWNsYWlyLWNvcmUvc3JjL21haW4vc2NhbGEvZnIvYWNpbnEvZWNsYWlyL3dpcmUvcHJvdG9jb2wvQ2hhbm5lbFRsdi5zY2FsYQ==) | `100.00% <100.00%> (ø)` | | | [.../acinq/eclair/wire/protocol/InteractiveTxTlv.scala](https://app.codecov.io/gh/ACINQ/eclair/pull/2783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ#diff-ZWNsYWlyLWNvcmUvc3JjL21haW4vc2NhbGEvZnIvYWNpbnEvZWNsYWlyL3dpcmUvcHJvdG9jb2wvSW50ZXJhY3RpdmVUeFRsdi5zY2FsYQ==) | `100.00% <ø> (ø)` | | | [...q/eclair/wire/protocol/LightningMessageTypes.scala](https://app.codecov.io/gh/ACINQ/eclair/pull/2783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ#diff-ZWNsYWlyLWNvcmUvc3JjL21haW4vc2NhbGEvZnIvYWNpbnEvZWNsYWlyL3dpcmUvcHJvdG9jb2wvTGlnaHRuaW5nTWVzc2FnZVR5cGVzLnNjYWxh) | `98.82% <100.00%> (+0.12%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/ACINQ/eclair/pull/2783/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ)