search

ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.23k stars 267 forks source link

Use bitcoinheaders.net v2 format #2787

Closed t-bast closed 9 months ago

t-bast commented 9 months ago

The format used by bitcoinheaders.net is changing to use whole bytes instead of nibles, which is easier to parse. We start using the v2 format exclusively, which will allow deprecating the previous format.

Thanks @thebluematt for notifying us.

Fixes #2786

codecov-commenter commented 9 months ago

Codecov Report

Merging #2787 (886f09c) into master (e73c1cf) will increase coverage by 0.06%. The diff coverage is 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2787 +/- ## ========================================== + Coverage 85.83% 85.90% +0.06% ========================================== Files 216 216 Lines 18169 18166 -3 Branches 753 756 +3 ========================================== + Hits 15596 15606 +10 + Misses 2573 2560 -13 ``` | [Files](https://app.codecov.io/gh/ACINQ/eclair/pull/2787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ) | Coverage Δ | | |---|---|---| | [...q/eclair/blockchain/watchdogs/HeadersOverDns.scala](https://app.codecov.io/gh/ACINQ/eclair/pull/2787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ#diff-ZWNsYWlyLWNvcmUvc3JjL21haW4vc2NhbGEvZnIvYWNpbnEvZWNsYWlyL2Jsb2NrY2hhaW4vd2F0Y2hkb2dzL0hlYWRlcnNPdmVyRG5zLnNjYWxh) | `17.77% <0.00%> (+1.11%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/ACINQ/eclair/pull/2787/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ)