search

ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.23k stars 267 forks source link

Update logback-classic to 1.2.13 #2796

Closed t-bast closed 9 months ago

t-bast commented 9 months ago

This version of logback fixes the following CVE:

"a potential denial of service attack on a centralized logback receiver when a third party controlling a remote appender connects to said receiver and could shut down or slow down logging of events."

Eclair isn't affected since we don't use logback receivers, but if there are applications or plugins that depend on eclair and use logback receivers, it's better to use the logback version containing the fix.

codecov-commenter commented 9 months ago

Codecov Report

Merging #2796 (c2a025f) into master (d4a498c) will decrease coverage by 0.07%. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2796 +/- ## ========================================== - Coverage 85.93% 85.86% -0.07% ========================================== Files 216 216 Lines 18177 18177 Branches 786 786 ========================================== - Hits 15620 15608 -12 - Misses 2557 2569 +12 ``` [see 10 files with indirect coverage changes](https://app.codecov.io/gh/ACINQ/eclair/pull/2796/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ)