search

ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.24k stars 266 forks source link

Activate dual funding by default #2825

Closed t-bast closed 8 months ago

t-bast commented 8 months ago

And update the release notes.

t-bast commented 8 months ago

I couldn't find the explanation of the switch in MinimalNodeFixture from DummyOnChainWallet to SingleKeyOnChainWallet.

Right, that's because the DummyOnChainWallet is overriding the makeFundingTx function which is used for single-funded channels, but its override of the fundTransaction function that is used for dual-funding is basically a no-op that returns the transaction as-is. This breaks dual funding entirely because it doesn't really return a funded transaction.

The SingleKeyOnChainWallet is a better mock for an on-chain wallet that supports funding transactions, which makes it work for dual funding tests.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.93%. Comparing base (fd0cdf6) to head (e551ecf).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2825 +/- ## ========================================== - Coverage 85.99% 85.93% -0.06% ========================================== Files 219 219 Lines 18453 18453 Branches 766 766 ========================================== - Hits 15869 15858 -11 - Misses 2584 2595 +11 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/ACINQ/eclair/pull/2825/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ)