search

ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.23k stars 267 forks source link

Fix flaky test #2833

Closed t-bast closed 6 months ago

t-bast commented 6 months ago

We started using dual-funding by default in some integration tests. One of the changes is that we consider the channel created once we send our commitment signatures. At that point, we are not yet in a state where we have fully signed commitments: that will happen once we receive our peer's signatures.

Some tests assumed that when receiving the ChannelCreated event, we would have fully signed commitment. We update those tests to handle the case where we are actually still exchanging signatures.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.00%. Comparing base (8723d35) to head (0a88186). Report is 3 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2833 +/- ## ======================================= Coverage 85.99% 86.00% ======================================= Files 219 219 Lines 18453 18453 Branches 766 766 ======================================= + Hits 15869 15870 +1 + Misses 2584 2583 -1 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/ACINQ/eclair/pull/2833/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ)