search

ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.24k stars 266 forks source link

Remove redundant check on `remoteScriptPubkey` #2844

Closed pm47 closed 7 months ago

pm47 commented 7 months ago

If the peer had option_shutdown_anysegwit enabled when they initially sent their remoteScriptPubkey, but reconnected later with option_shutdown_anysegwit disabled, then isValidFinalScriptPubkey may not pass anymore.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.95%. Comparing base (c8184b3) to head (fe0b88f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2844 +/- ## ========================================== - Coverage 85.96% 85.95% -0.01% ========================================== Files 219 219 Lines 18441 18438 -3 Branches 762 802 +40 ========================================== - Hits 15853 15849 -4 - Misses 2588 2589 +1 ``` | [Files](https://app.codecov.io/gh/ACINQ/eclair/pull/2844?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ) | Coverage Δ | | |---|---|---| | [...c/main/scala/fr/acinq/eclair/channel/Helpers.scala](https://app.codecov.io/gh/ACINQ/eclair/pull/2844?src=pr&el=tree&filepath=eclair-core%2Fsrc%2Fmain%2Fscala%2Ffr%2Facinq%2Feclair%2Fchannel%2FHelpers.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ#diff-ZWNsYWlyLWNvcmUvc3JjL21haW4vc2NhbGEvZnIvYWNpbnEvZWNsYWlyL2NoYW5uZWwvSGVscGVycy5zY2FsYQ==) | `94.50% <ø> (-0.04%)` | :arrow_down: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/ACINQ/eclair/pull/2844/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACINQ)