search

ACINQ / eclair

A scala implementation of the Lightning Network.
Apache License 2.0
1.24k stars 266 forks source link

warnings field changes from string to array in bitcoin core 28 #2921

Open DerEwige opened 1 week ago

DerEwige commented 1 week ago

bitcoin core 28 comes with a breaking change in the warnings field:

https://github.com/bitcoin/bitcoin/pull/29845

Has this already been taking into account in eclair

t-bast commented 1 week ago

No, as documented eclair doesn't support bitcoind 28 yet. This would be use at your own risk! We'll be updating to bitcoind 28 at some point, you should wait for this to be released before updating your bitcoin node.

DerEwige commented 1 week ago

I’m aware that bitcoind 28 is not yet supported. It should work though when setting this in the config

deprecatedrpc=warnings

I assume you will want to move to it so you can make use of the package relay feature, to simplify CPFP in FC scenarios?

t-bast commented 1 week ago

It's not as simple. We can only benefit from additional propagation once enough bitcoin nodes have upgraded to 28.

Also, updating to bitcoind 28 breaks some of our tests, which means we need to investigate what changed and make sure there's no regression in eclair when upgrading.

This will be done and included in a future release.