ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
616 stars 93 forks source link

[UI] Inconsistency in `Recovery seed` `recovery phrase` `backup phrase` #184

Open pavlenex opened 2 years ago

pavlenex commented 2 years ago

Hey guys, love the wallet, been a while since I last used it, major improvements since the early releases.

I've tasked myself to look into the UI of Phoenix and I've teared down screens in Figma.

One of the first things that caught my eye is inconsistency in naming of Recovery phrase.

If you go to > Settings > Recovery Phrase the screen you see refers to the same thing with different names. Naming these inconsistently may lead to user-confusion, so I would like to propose the unification of the term.

IMG_2001

IMG_2002

Screenshot 2021-09-24 at 14 45 11

Screenshot 2021-09-24 at 14 53 16

In the Bitcoin Design Guide, we've named it Recovery phrase but I think Backup phrase is also great. If in the future there's multilingual option to the wallet, phrase is easier to translate.

What do you think, would this be something you'd like to unify thought the wallet?

pavlenex commented 2 years ago

By the way if these sort of suggestions are useful to you guys, I can post a few more as a separate issues.

dpad85 commented 2 years ago

Hey, thanks for reporting those issues and also for the review on Figma. I think Recovery phrase works well but it's a bit long and descriptive, and it does not really convey the fact that it is private and secret. Lately I've been using private key or simply key, because it's a short word, and everyone knows what a key is and that it must be kept safe.

So I think we should unify the naming and use key as the shorthand (not seed) and recovery phrase to describe what that is.

pavlenex commented 2 years ago

Another angle to look at this would be from the point of:

I think this can complement well with what's been mentioned in https://github.com/ACINQ/phoenix/issues/204