ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
674 stars 97 forks source link

Accessibility Tests performed #290

Open mouxdesign opened 2 years ago

mouxdesign commented 2 years ago

Myself and Christoph did some accessibility testing today on the Phoenix wallet.

Overall the accessibility was quite good. We found a few things that can be optimized:

To provide a brief overview of what we are doing:

mouxdesign commented 2 years ago

Have done some follow up tests on the receive flow which I recorded as well. This was a voice over only test performed on the Receive flow of Phoenix.

Summary of findings: Overall the app is quite accessible with regards to voice over features, some areas could could be improved are:

Link to google doc with video and notes how the app was analyzed and what actions were performed.

dpad85 commented 2 years ago

Hello, thanks for testing the app and providing such a detailed feedback. Regarding Android we are completely reworking the app so some of the accessibility issues you found may just disappear, and new ones will certainly be created! Accessibility is something we will look at once the new Android app is ready to ship. Hopefully, jetpack-compose should make things easy to fix.

robbiehanson commented 2 years ago

@mouxdesign Thank you so much ! This is incredibly helpful !

GBKS commented 1 year ago

Accessibility day is coming up on May 18 and in the Bitcoin Design Community we're looking to rally designers and developers to spend that day learning about accessibility and making improvements. Would you be interested in joining? Doesn't have to be a huge effort, could be simply about making some of the easier fixes of what is posted in this issue.

robbiehanson commented 11 months ago

Just wanted to note that I spent a fair amount of time fixing a lot of accessibility issues earlier this year. So the iOS tests may need to be updated.

mouxdesign commented 11 months ago

@robbiehanson Great to see this! Would it help if we re-tested the application?

robbiehanson commented 11 months ago

Would it help if we re-tested the application?

Yes, that would be super helpful. We fixed many issues, but then we made large changes across the app for version 2. So I may have broken several things since then.

GBKS commented 10 months ago

We fixed many issues

So awesome to hear. I just did a quick test and the app is in really good shape (Version 2.1.0 on iPhone 15). Thank you for digging into this.

I found a handful of smaller issues that I documented here.

Phoenix accessibility test summary 240105

Great job adding in the tap-and-hold actions on the receive screen. A bit hard to discover, but super useful.

I am curious as to what user feedback you are getting for the "add liquidity" flow. I see you're using metaphors to explain the concept, I wonder if it clicks for people. Do you also explain these concepts on onboarding or is the "add liquidity" screen the first time people encounter them?