search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
644 stars 97 forks source link

LBP fiat currency addition #344

Closed marcondy closed 1 year ago

marcondy commented 1 year ago

It would be great to have integrated the real market rate of LBP ( Lebanese Lira )

API documentation

https://api.yadio.io/convert/1/BTC/LBP

Thank you in advance.

dpad85 commented 1 year ago

Good idea and thanks for the API endpoint, it seems there's a large discrepancy with the rate we use. I don't think we'll be able to deliver this quickly though.

marcondy commented 1 year ago

Good idea and thanks for the API endpoint, it seems there's a large discrepancy with the rate we use. I don't think we'll be able to deliver this quickly though.

Thank you for your prompt response, no worries as long as it's going to be correct eventually.

Majority of converters online use the "official" rate , therefore it's been wrong for over three years now.

Thank you again

robbiehanson commented 1 year ago

Is there a "common name" for the free market rate (to differentiate it from the official rate) ?

For example, in Argentina it's commonly called the "blue market" (or "dólar blue" or "mercado azul"). So we named the currency "Argentine Peso (blue market)" - ARSbm

When we added support for Cuban Pesos I wasn't aware of any such "common name", so we simply called it "Cuban Pesos (free market)" - CUPfm

We could do the same here: "Lebanese Pound (free market)" - LBPfm

Unless there's a common name already in circulation? Let me know your thoughts.

marcondy commented 1 year ago

Yes , they common name for street USD value is the "Black Market"

robbiehanson commented 1 year ago

Support for this feature has been merged into master. For iOS this means it should be available in v1.6.1 (or v2.0.0 whichever arrives first). For Android it should be available in the next major release.