search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
644 stars 97 forks source link

Deterministic build? #357

Closed Barondane closed 1 year ago

Barondane commented 1 year ago

Hello there!

Is the build deterministic yet? I tried to build and reproduce but failed. I suspected at first that my local environment was not setup right. I was debugging for a while and tried Xcode for IOS only build which should be quite straightforward but no luck.

What could could have gone wrong?

dpad85 commented 1 year ago

Hello, the iOS build is not deterministic, no work has been done on that yet. The Android build used to be deterministic, but it is not anymore because of issues with the SQLDelight dependency which generates classes in a non-deterministic way (see #112). So you will have differences.

A major rework of the app is on the way (and has been for while actually). Once it's done and things are stable we will have time to work on this. Note that this will involve the lightning-kmp lib (and some other others), so I'm not sure how this will work with Kotlin Multiplatform, but we'll try. I'm closing this issue as #112 has precedence.