ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
662 stars 96 forks source link

Add missing currencies: VES & MLC #377

Open grunch opened 1 year ago

grunch commented 1 year ago

Hi, I'm working on @lnp2pbot, lately we have an increase of phoenix wallet users and I started to receive one question from latam users, why my currency is not listed?

It's important to let you know that some countries in latam have currency controls so we shouldn't use official rate APIs because is not the real one, I propose to use the api from this site which have the free market fiat currencies rate from all around the world and we are using it since almost two years ago.

https://yadio.io/api.html

Here the most used latam fiat currencies:

VES: https://api.yadio.io/rate/VES ARS: https://api.yadio.io/rate/ARS COP: https://api.yadio.io/rate/COP CUP: https://api.yadio.io/rate/CUP MLC: https://api.yadio.io/rate/MLC CLP: https://api.yadio.io/rate/CLP CRC: https://api.yadio.io/rate/CRC GTQ: https://api.yadio.io/rate/GTQ PYG: https://api.yadio.io/rate/PYG PAB: https://api.yadio.io/rate/PAB PEN: https://api.yadio.io/rate/PEN BOB: https://api.yadio.io/rate/BOB HNL: https://api.yadio.io/rate/HNL UYU: https://api.yadio.io/rate/UYU

Yadio also have this useful converter

https://api.yadio.io/convert/1000/ars/BTC # this converts 1000 ARS to BTC

diegogurpegui commented 1 year ago

This would be really helpful!

cristabileok commented 1 year ago

Great suggestion, let's hope they take it into consideration.

There are many latin-america countries where bitcoin is growing fast and this would certainly help.

Greetings from Argentina.

dpad85 commented 1 year ago

Hello, this will be fixed in the next release of the Android app. Phoenix will support conversion to most fiat currencies (and also fix inaccuracies).

dpad85 commented 1 year ago

Closing this ticket as it is fixed by version 2.x, which can now be used by all Android users (after migration). If the app is still missing a currency (especially a free market currency), let us know.

grunch commented 1 year ago

Hi @dpad85 is it a good reason to not having Venezuelan Bolívar (VES) rate on phoenix?

robbiehanson commented 1 year ago

Here's the current status:

In the case of both ARS & CUP, we also provide the official (government controlled) exchange rate. That is, the exchange rate for ARS is coming from Yadio. And there's a separate currency called "ARSoff" which represents the "official" exchange rate.

grunch commented 1 year ago

Here's the current status:

* [x]  ARS: Argentine Peso

* [x]  BOB: Bolivian Boliviano

* [x]  CLP: Chilean Peso

* [x]  COP: Colombian Peso

* [x]  CRC: Costa Rican Colón

* [x]  CUP: Cuban Peso

* [x]  GTQ: Guatemalan Quetzal

* [x]  HNL: Honduran Lempira

* [ ]  MLC: Cuban Moneda Libremente Convertible

* [x]  PAB: Panamanian Balboa

* [x]  PEN: Peruvian Sol

* [x]  PYG: Paraguayan Guarani

* [x]  UYU: Uruguayan Peso

* [ ]  VES: Venezuelan Bolívar

In the case of both ARS & CUP, we also provide the official (government controlled) exchange rate. That is, the exchange rate for ARS is coming from Yadio. And there's a separate currency called "ARSoff" which represents the "official" exchange rate.

Hi @robbiehanson thank you for your response, yes I saw that you address the official rate of some countries with currency control, if I may I can advise that remove the official rate because that is a way politicians scam their own citizens, my whole life I've been under currency control first in Venezuela and now in Argentina, where I'm based now, in these countries people use free market currency rate to live, having two currency rates can confuse tourists that are not used to having two rates for the same currency.

MLC is used in cuba, it's kinda a CBDC from cuban dictators.