search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
632 stars 95 forks source link

Splicing support in iOS #389

Closed robbiehanson closed 11 months ago

robbiehanson commented 1 year ago

There's a lot of changes, but mostly the UI mirrors what we have in Android. I'll try to showcase the highlights with screenshots:

There's a new "Channel management" option in Settings:

The default "max absolute fee" is currently 5,000 sat (as defined in kotlin layer), and the UI provides helpful info when the user changes the value:   

The "advanced options" are initially hidden behind a button. But when revealed, we try to make the confusing stuff less confusing with a helpful interactive example:

^ the example values change as the user changes either "max fee amount" or "max fee percent"

The policy override is available too:

Fee warnings have been integrated into the Receive screen:

There's a new notifications screen that includes things like rejected swap-in attempts:  

There's more work yet to be done, but this is already a large PR.

robbiehanson commented 1 year ago

I just noticed this PR includes PR #386 by mistake. So after that PR is closed, I will rebase this PR

robbiehanson commented 11 months ago

navigation to the channels management screen from the swap-in wallet info screen does not work (navigation does open the channel management screen, but always ends up back on the swap-in wallet screen)

Good catch. Fixed in https://github.com/ACINQ/phoenix/pull/389/commits/7e961f0898739371ff7dea645017190c3bd90402

robbiehanson commented 11 months ago

after bumping the feerate of a payment, we should probably navigate to the main screen, instead of staying on the screen of the transaction that is being bumped. That way the user can see the new payment bumping the feerate.

Done in https://github.com/ACINQ/phoenix/pull/389/commits/14e09c92a7cd0ef6c69b34eb808a94d60a69c7dc