search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
662 stars 96 forks source link

Don't require TLS connection when connecting to localhost or onion addresses #4

Open Kixunil opened 4 years ago

Kixunil commented 4 years ago

When an address matching regex ^(localhost|127.0.0.1|.*\.onion)(:[1-9][0-9]*)?$ is entered, show a checkbox "Disable TLS", as the encryption might not be needed.

This is useful for example when one sets up an SSH tunnel using ConnectBot.

tomichec commented 4 years ago

the required change can be done here: https://github.com/ACINQ/phoenix/blob/3ed8cae1f32d89e44a00236792e3e92a311c7b9d/app/src/main/java/fr/acinq/phoenix/lnurl/LNUrl.kt#L67

Kixunil commented 4 years ago

That looks like LNURL, I was talking about connecting to a custom node.

dpad85 commented 4 years ago

Hi, from v1.3.2 you can disable/enable TLS when connecting to an onion electrum server (it's disabled by default) so this issue is half fixed. What needs to be done is to add the same behaviour for localhost|127.0.0.1 addresses.

tomichec commented 4 years ago

It would also be useful to have this behavior for lnurl.

slush0 commented 3 years ago

Please allow connecting to non-ssl electrum nodes. There are setups when it is completely unnecessary or even impossible to fulfill this requirement. I'm using Electrum server in private network behind VPN and it is very hard to generate ssl cert for publicly unreachable machines.

Kixunil commented 3 years ago

It would also be useful to have this behavior for lnurl.

For onion only, I don't believe LNURL is useful for localhost queries.

@slush0 good point about VPN, that'd be hard to check correctly as I suggested. Maybe allow it with big fat warning?

slush0 commented 1 year ago

Any progress on this? Custom servers to require SSL is really limiting. Please allow to skip this requirement.