ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
671 stars 96 forks source link

Add checksum to descriptor #402

Open Sjors opened 1 year ago

Sjors commented 1 year ago

I was able to import the swap-in wallet descriptor into a Bitcoin Core watch-only wallet. But I had to manually add the checksum.

https://github.com/bitcoin/bips/blob/master/bip-0380.mediawiki#user-content-Checksum

t-bast commented 1 year ago

Right, we initially didn't have the checksum code written yet, and didn't update to include it, but that should be easy to do.