ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
632 stars 95 forks source link

Update for `ElectrumClient` rework #418

Closed dpad85 closed 10 months ago

dpad85 commented 10 months ago

The ElectrumClient has been reworked in https://github.com/ACINQ/lightning-kmp/pull/512, fixing several issues and generally improving the reliability of the client. The impact on Phoenix codebase is small.

@robbiehanson A notable addition is the timeout to connect (default is 15s, and for now we use that value).

Also note that the connectionState flow has been removed, the client now exposes a flow of ElectrumConnectionStatus - that can be easily converted to a more generic Connection object.

This has been successfully tested on Android and iOS, and can be merged as-is. However the nature of the issues and the fixes provided by this rework means that we'll have to keep an eye on this.