search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
656 stars 97 forks source link

Compatibility with Xcode 15 #422

Closed dpad85 closed 1 year ago

dpad85 commented 1 year ago

Xcode 15 brings a new ld_prime static linker which is not compatible with kotlin < 1.9.10. This workaround forces xcode to use ld64, until we move to kotlin 1.9.10. See https://youtrack.jetbrains.com/issue/KT-60230/Native-unknown-options-iossimulatorversionmin-sdkversion-with-Xcode-15-beta-3 for details.

@robbiehanson There's another issue with wasDisconnected in MempoolMonitor.swift, method startNetworkMonitor. Can you take a look?

robbiehanson commented 1 year ago

Note that I dropped the check: if (System.getenv("XCODE_VERSION_MAJOR") == "1500")

That check works if you build within Xcode (because Xcode specifically exports that environment variable). But it doesn't work if you build on the command line. Or within Android Studio. Or if you try to run unit tests.

So I recommend we drop the check, and just say that Xcode 15 is now required to build for iOS.