ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
624 stars 93 forks source link

(android) Show recently rejected payments in Home #426

Closed dpad85 closed 9 months ago

dpad85 commented 9 months ago

This PR adds a message that summarises recently rejected payments (due to the user's fee policy).

On Android we already show a system notification when such events occurred, but these notifications are easy to miss, (system gives them low priority, or system notifications are disabled). The user is confused about why the payment seemingly never arrived - so we need to display a message.

This message only counts offchain payments rejected less than 3 hours ago. Clicking on that message redirects to the notifications list.

@robbiehanson this is similar to what was done in https://github.com/ACINQ/phoenix/pull/423 although I preferred not to show the full details of 1 single rejection (it takes a lot of place). It's more discreet that way, and the user can still get the details by clicking on the message.

1 payment rejected with 2 important messages

We display two messages, one about the rejected payment, and the other like before, displaying the important with highest priority. Clicking on any of these messages redirects to the notifications list screen.

3 payments rejected with no important messages

robbiehanson commented 9 months ago

We display two messages, one about the rejected payment, and the other like before, displaying the important with highest priority.

This is a great improvement! I will copy this on iOS.

This message only counts offchain payments rejected less than 3 hours ago.

Maybe the time duration should be longer. If I miss a payment while sleeping, it would be nice to still see it on the Home screen.

1 payment rejected recently

Mild suggestion: "1 incoming payment rejected recently" (possibly more clear, but not convinced this is an improvement)