search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
624 stars 93 forks source link

Phoenix doesn't allow choice in BIP21 with BOLT11 in deep link #466

Closed NicolasDorier closed 7 months ago

NicolasDorier commented 8 months ago

I use Phoenix (2.0.12) on Android, when I click on the button "Pay in Wallet" with a BIP21 having a lightning=, I am not presented with a choice as I would if I just scanned the QR Code.

You can check with the following,

Here a QR Code to open the app on mobile:

image

What you see: On-Chain payment without amount prefilled. What I am expecting: Same experience as QR Code, ie, it should ask me to pay on lightning or on-chain, and prefill the sats amount.

First question: If on-chain payment is selected by default, why the sats amount isn't even prefilled. Second question: on-chain payment shouldn't be selected at all, instead the app should give the choice to select lightning.

Link to: https://github.com/btcpayserver/btcpayserver/issues/5455

dpad85 commented 8 months ago

Thanks for reporting this. It's a bug in the logic forwarding the bitcoin uri to the scanner, hence the amount not being filled in the payment screen, and the dialog to choose a between on-chain/off-chain being missing.

NicolasDorier commented 7 months ago

I look forward to see this one fixed!

Some retail merchants, rather than opening the invoice on their own device and let the customer pay as you usually see, instead they only show a QR code with the keypad app I shared in the description.

The customer scans the QR code, enter the amount, and pay on his own device. The fact the "Pay in wallet" doesn't work break the payment flow.

dpad85 commented 7 months ago

This will be available in the next release. Thanks for your patience!