ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
619 stars 93 forks source link

(android) Skip TLS check for onion Electrum servers #479

Closed dpad85 closed 7 months ago

dpad85 commented 7 months ago

This PR fixes an issue where Phoenix was checking the TLS certificates even for onion servers. This check is redundant so by default, should be skipped.

There's also a bug (maybe in lightning-kmp) that makes the TLS connection fail for onion addresses. This issue needs further investigation and it will be fixed in a later PR.

Additionally this PR adds a notice in the dialog for connecting to a custom Electrum server to help users know what port they should use (for onion address, use the plain TCP port, otherwise always use the TLS port).

image

@robbiehanson I've only updated the Android app, but I think this will also need a fix on iOS.