Use `Try` pattern when reading a `PaymentRequest`

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.

https://phoenix.acinq.co

Apache License 2.0

619 stars 93 forks source link

Use `Try` pattern when reading a `PaymentRequest` #492

Closed dpad85 closed 5 months ago

dpad85 commented 6 months ago

This PR adds support for https://github.com/ACINQ/lightning-kmp/pull/567, making the method parsing invoices use the runTrying pattern matching.

That PR in lightning-kmp also catches encoding issues in invoices, but this has not yet been tested on Phoenix.

@robbiehanson this should not need any changes in iOS since invoice parsing is delegated to the shared layer, but let me know if I'm missing anything!