ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
616 stars 93 forks source link

[Bug] No currency conversion in "Technical details" page #535

Open dluvian opened 3 months ago

dluvian commented 3 months ago

In the "Technical details" page the (now) fiat values are calculated correctly but the (then) values are not. The number always stays the same even after changing the fiat currency in the display settings.

Example:

robbiehanson commented 1 month ago

Note that, when this is fixed, it will display "1 EUR (then)".

This is because we only store a single original amount (in this case EUR). We support 150+ fiat currencies, so we don't store the original amount in every single currency for every single payment.

This could possibly be improved. If you regularly switch your fiat currency in Phoenix, please let us know your use case. We're always interested in learning how the app is used (especially in ways we didn't anticipate).

dluvian commented 1 month ago

I switch the currency based on where I currently live.