ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
682 stars 98 forks source link

Handle new outgoing payment failures #563

Closed dpad85 closed 6 months ago

dpad85 commented 6 months ago

This PR supports the new outgoing payment failures types added in https://github.com/ACINQ/lightning-kmp/pull/634.

There is a small impact on the payments database, as the status of failed parts are stored using a code: Int json (with an optional String message).

@robbiehanson we should remove the details for failed parts on iOS. Instead, show a single error message using the OutgoingPaymentFailure.explain() method that will pick the most pertinent error for a given payment (will return either a FinalFailure error, or a Part.Status.Failure)