search

ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
654 stars 97 forks source link

(android) Add fee warning message in lnurl-withdraw screen #567

Closed dpad85 closed 3 months ago

dpad85 commented 4 months ago

Withdrawals over LNURL are subject to the same liquidity constraints as regular Lightning payments, so a warning should be displayed.

It's actually even more important to have a liquidity warning here, since many LNURL services (e.g. Telegram bots) do not handle failed payments well and declare the withdrawal has been consumed, even when the payment was not received.

This PR also improves the regular Receive screen on Android, where the fee warning message dialog was opened systematically, even when the user had just seen it.

dpad85 commented 4 months ago

Note that this PR currently depends on #563, and will need to be rebased once that other PR is merged.

dpad85 commented 4 months ago

@robbiehanson if the iOS app does not have the fee warning in the lnurl-withdraw screen either, you can fix that in this PR as well.

dpad85 commented 4 months ago

Example with a testnet withdrawal:

image

The warning dialog is the same as in the Receive screen. The clickable "Payment will fail" message is also the same.