ACINQ / phoenix

Phoenix is a self-custodial Bitcoin wallet using Lightning to send/receive payments.
https://phoenix.acinq.co
Apache License 2.0
643 stars 97 forks source link

Allow invoice expiry of 3 days or less #592

Open NadAlaba opened 1 month ago

NadAlaba commented 1 month ago

Currently in the android app, the invoice expiry can be changed between 1, 2, or 3 weeks only. However, some CEX (like kucoin) and other custodial wallets like WOS, don't allow invoices with an expiry of more than 3 days, which is making transactions to fail.

I thought I once saw a commit that allows changing the expiry between 1 second and 999999 seconds, but I'm not able to set it to less than a week in the app right now :strange:

Possibly related issue #335

dpad85 commented 1 month ago

I'm not able to reproduce the issue with WoS. I can pay a Phoenix generated invoice from WoS without errors, even with an expiry of 1 week or 3 weeks. I cannot test with the Kucoin CEX though. Are you sure it's related to Bolt11 invoices expiry values? Do you have an error message from these services you can share?

I thought I once saw a commit that allows changing the expiry between 1 second and 999999 seconds

That was in the legacy app, you could enter any expiry you wanted. In the v2 app, the app only let you choose between fixed values to make things simpler.

NadAlaba commented 1 month ago

Strangely sending from WOS is working now, last time it failed after sending from Kucoin had failed made me assume it was the same reason. However, sending from Kucoin is still not working, and unfortunately they don't forward any error message to their users. After speaking with customer support, this is what they said

Upon investigation, we have noticed that the expiry time you have configured is a week time. However, KuCoin only currently support the expiry time for up to 72 hours. Please configure the expiry time to 72 hours so that you are able to do a successful withdrawal.

In the v2 app, the app only let you choose between fixed values to make things simpler.

Unfortunately, this decision does not make it simpler for me 😞

dpad85 commented 1 month ago

The fix will be available in the next Android version.

For iOS, we'll need a separate commit so I reopen the ticket.