ACINQ / phoenixd

https://phoenix.acinq.co/server
Apache License 2.0
117 stars 15 forks source link

Add a best-effort method for estimating liquidity fees #107

Closed pm47 closed 3 months ago

pm47 commented 3 months ago

Returns a best-effort estimate of liquidity fees for a given amount.

Note that:

./phoenix-cli estimateliquidityfees --amountSat 2000000
{
    "miningFeeSat": 1219,
    "serviceFeeSat": 20000
}

See #88,#104.

pm47 commented 3 months ago

Since the feerate that phoenixd uses internally is not the feerate that will be used for pay-to-open (it will be a feerate decided by the LSP)? Or we don't care for now since this will get better with the new on-the-fly funding, at which point we will know the feerate that will be used?

It's not the same because of sampling frequency, but it's the same source (phoenix gets its feerate from mempool.space, not electrum). I'd keep things simple, waiting for the new on-the-fly.

danielcharrua commented 3 months ago

@pm47 this is great!!

Would be nice to add this to the API docs.

Also, is there any guide on how to update the software? I installed using wget as stated on the "get started"